Skip to content

feat(cleanup): refuse to retire a task while an issue it names is open - #2830

Open
fpresta0607 wants to merge 8 commits into
mainfrom
fix/2821-issue-settling
Open

fpresta0607 wants to merge 8 commits into
mainfrom
fix/2821-issue-settling

Conversation

@fpresta0607

@fpresta0607 fpresta0607 commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

What Changed

  • goblins cleanup now stops before changing anything if an issue the task names is still open, or is gone, on GitHub. This also applies with --force-archive. The task's issues come from three places: its brief (Task, Acceptance criteria and ## ADDED sections), the --closes value of its gate runs, and its pull requests (GitHub closing links, closing words or "Part of" in the PR body). --keep-issue-open <issue> --reason "<why>" lets the cleanup go ahead and records issue-kept-open: <issue>: <reason> in the task's status log. goblins kill still checks no issues.
  • New read-only goblins issue unowned command. For each project of the home, it lists the open issues without the ops-root label that no live or queued task names. It lists separately the open issues that only finished or parked tasks name. At the end it names anything it could not read.
  • New shared helpers back both commands: internal/tickets gets issue reference parsing, open-issue lookup and pull-request issue reads, and internal/pipeline reads gate-run closing issues. Usage text and docs are updated (docs/commands/cleanup.md, new docs/commands/issue/unowned.md, delivery and ownership contracts).

Risk Assessment

Validation text withheld because intent publication is disabled. Full results remain in the local run record. Recorded finding counts by snapshot: Intent: final unavailable, rounds [1: unavailable]; Rebase: final unavailable, rounds [1: unavailable]; Review: final 0, rounds [1: 1, 2: 0]; Test: final 0, rounds [1: 0]; Document: final 0, rounds [1: 0]; Lint: final unavailable, rounds [1: unavailable]; gate.lint.tests-kept: final unavailable, rounds [1: unavailable]; Push: final unavailable, rounds [1: unavailable].

Pipeline

Updates from git push no-mistakes

  • Intent: completed

  • Rebase: completed

  • Review: completed

  • Test: completed

  • Document: completed

  • Lint: completed

  • gate.lint.tests-kept: completed

  • Push: completed

Issues

Closes #2821

Retired goblins left 22 open issues named only by finished tasks, and 83
more outside the root clean-up named by no task. goblins cleanup now reads
the issues a task names (its brief, its gate runs' --closes, its pull
requests) and refuses while one is open, unless the CEO keeps it open with
--keep-issue-open <issue> --reason, which the task's status log records.
goblins kill and reap do not check, since they stop work unfinished.

goblins issue unowned lists, per project, the open issues without the
ops-root label that no live or queued task names, and apart those only
finished or parked tasks name, so the backlog of unowned issues can be
settled.
The first real run of goblins issue unowned listed eight issues as named by
no task although a live or queued task names them, six of them in a section
the CEO appended to a brief under "## ADDED", which the brief reader
skipped: cleanup would have retired those tasks with the issues open. An
added section is now read as a Task of its own, together with the "issue N"
and "issues N and M" words the CEO writes there and in its heading. The
cleanup usage line also names the refusal of a gone issue and the command's
flags.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A finished task can leave its issue open, and nothing lists open issues no task owns

1 participant