Repository navigation
feat(cleanup): refuse to retire a task while an issue it names is open - #2830
Open
fpresta0607 wants to merge 8 commits into
Open
fpresta0607 wants to merge 8 commits into
fpresta0607 wants to merge 8 commits into
Conversation
Retired goblins left 22 open issues named only by finished tasks, and 83 more outside the root clean-up named by no task. goblins cleanup now reads the issues a task names (its brief, its gate runs' --closes, its pull requests) and refuses while one is open, unless the CEO keeps it open with --keep-issue-open <issue> --reason, which the task's status log records. goblins kill and reap do not check, since they stop work unfinished. goblins issue unowned lists, per project, the open issues without the ops-root label that no live or queued task names, and apart those only finished or parked tasks name, so the backlog of unowned issues can be settled.
This was referenced Nov 20, 2026
The first real run of goblins issue unowned listed eight issues as named by no task although a live or queued task names them, six of them in a section the CEO appended to a brief under "## ADDED", which the brief reader skipped: cleanup would have retired those tasks with the issues open. An added section is now read as a Task of its own, together with the "issue N" and "issues N and M" words the CEO writes there and in its heading. The cleanup usage line also names the refusal of a gone issue and the command's flags.
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
goblins cleanupnow stops before changing anything if an issue the task names is still open, or is gone, on GitHub. This also applies with--force-archive. The task's issues come from three places: its brief (Task, Acceptance criteria and## ADDEDsections), the--closesvalue of its gate runs, and its pull requests (GitHub closing links, closing words or "Part of" in the PR body).--keep-issue-open <issue> --reason "<why>"lets the cleanup go ahead and recordsissue-kept-open: <issue>: <reason>in the task's status log.goblins killstill checks no issues.goblins issue unownedcommand. For each project of the home, it lists the open issues without theops-rootlabel that no live or queued task names. It lists separately the open issues that only finished or parked tasks name. At the end it names anything it could not read.internal/ticketsgets issue reference parsing, open-issue lookup and pull-request issue reads, andinternal/pipelinereads gate-run closing issues. Usage text and docs are updated (docs/commands/cleanup.md, newdocs/commands/issue/unowned.md, delivery and ownership contracts).Risk Assessment
Validation text withheld because intent publication is disabled. Full results remain in the local run record. Recorded finding counts by snapshot: Intent: final unavailable, rounds [1: unavailable]; Rebase: final unavailable, rounds [1: unavailable]; Review: final 0, rounds [1: 1, 2: 0]; Test: final 0, rounds [1: 0]; Document: final 0, rounds [1: 0]; Lint: final unavailable, rounds [1: unavailable]; gate.lint.tests-kept: final unavailable, rounds [1: unavailable]; Push: final unavailable, rounds [1: unavailable].
Pipeline
Updates from git push no-mistakes
Intent: completed
Rebase: completed
Review: completed
Test: completed
Document: completed
Lint: completed
gate.lint.tests-kept: completed
Push: completed
Issues
Closes #2821